fix: block updating mutable parameters

kylecarbs · kylecarbs · commit d10cc2b14876 · 2023-03-22T00:31:44.000Z
diff --git a/site/src/api/api.test.ts b/site/src/api/api.test.ts
@@ -2,6 +2,7 @@ import axios from "axios"
 import {
   MockTemplate,
   MockTemplateVersionParameter1,
+  MockTemplateVersionParameter2,
   MockWorkspace,
   MockWorkspaceBuild,
   MockWorkspaceBuildParameter1,
@@ -184,7 +185,10 @@ describe("api.ts", () => {
       jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValue([])
       jest
         .spyOn(api, "getTemplateVersionRichParameters")
-        .mockResolvedValue([MockTemplateVersionParameter1])
+        .mockResolvedValue([
+          MockTemplateVersionParameter1,
+          { ...MockTemplateVersionParameter2, mutable: false },
+        ])
 
       let error = new Error()
       try {
@@ -194,6 +198,8 @@ describe("api.ts", () => {
       }
 
       expect(error).toBeInstanceOf(api.MissingBuildParameters)
+      // Verify if the correct missing parameters are being passed
+      // It should not require immutable parameters
       expect((error as api.MissingBuildParameters).parameters).toEqual([
         MockTemplateVersionParameter1,
       ])
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -976,7 +976,9 @@ const getMissingParameters = (
   templateParameters: TypesGen.TemplateVersionParameter[],
 ) => {
   const missingParameters: TypesGen.TemplateVersionParameter[] = []
-  const requiredParameters = templateParameters.filter((p) => p.required)
+  const requiredParameters = templateParameters.filter(
+    (p) => p.required && p.mutable,
+  )
 
   for (const parameter of requiredParameters) {
     // Check if there is a new value
