fix: resolve flake in log sender by checking context (#9865)

kylecarbs · web-flow · commit d3220c5db9ce · 2023-09-25T22:19:27.000Z
See: https://github.com/coder/coder/actions/runs/6305051172/job/17117693579
diff --git a/codersdk/agentsdk/logs.go b/codersdk/agentsdk/logs.go
@@ -153,7 +153,7 @@ func LogsSender(sourceID uuid.UUID, patchLogs func(ctx context.Context, req Patc
 				// error occurs. Note that we use the main context here,
 				// meaning these requests won't be interrupted by
 				// shutdown.
-				for r := retry.New(time.Second, 5*time.Second); r.Wait(ctx); {
+				for r := retry.New(time.Second, 5*time.Second); r.Wait(ctx) && ctx.Err() == nil; {
 					err := patchLogs(ctx, PatchLogs{
 						Logs:        backlog,
 						LogSourceID: sourceID,
