remove mutex on sub close

ethanndickson · ethanndickson · commit dbc95150ca82 · 2024-11-01T03:18:05.000Z
diff --git a/coderd/workspaceupdates.go b/coderd/workspaceupdates.go
@@ -110,8 +110,6 @@ func (s *sub) start(ctx context.Context) (err error) {
 func (s *sub) Close() error {
 	s.cancelFn()
 
-	s.mu.Lock()
-	defer s.mu.Unlock()
 	if s.psCancelFn != nil {
 		s.psCancelFn()
 	}

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,6 @@ func (s *sub) start(ctx context.Context) (err error) {`
`110`	`110`	`func (s *sub) Close() error {`
`111`	`111`	`s.cancelFn()`
`112`	`112`
`113`		`- s.mu.Lock()`
`114`		`- defer s.mu.Unlock()`
`115`	`113`	`if s.psCancelFn != nil {`
`116`	`114`	`s.psCancelFn()`
`117`	`115`	`}`