Skip to content

Commit ded5685

Browse files
committed
Comment why the audit log does not work
1 parent 28deaca commit ded5685

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

coderd/database/queries.sql.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

codersdk/workspaceproxy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ type ProxyHealthReport struct {
4848
type WorkspaceProxy struct {
4949
ID uuid.UUID `json:"id" format:"uuid" table:"id"`
5050
Name string `json:"name" table:"name,default_sort"`
51-
DisplayName string `json:"display_name" table:"display_name""`
51+
DisplayName string `json:"display_name" table:"display_name"`
5252
Icon string `json:"icon" table:"icon"`
5353
// Full url including scheme of the proxy api url: https://us.example.com
5454
URL string `json:"url" table:"url"`

enterprise/coderd/workspaceproxy.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -410,9 +410,12 @@ func (api *API) workspaceProxyIssueSignedAppToken(rw http.ResponseWriter, r *htt
410410
// @x-apidocgen {"skip": true}
411411
func (api *API) workspaceProxyRegister(rw http.ResponseWriter, r *http.Request) {
412412
var (
413-
ctx = r.Context()
414-
proxy = httpmw.WorkspaceProxy(r)
415-
auditor = api.AGPL.Auditor.Load()
413+
ctx = r.Context()
414+
proxy = httpmw.WorkspaceProxy(r)
415+
auditor = api.AGPL.Auditor.Load()
416+
// TODO: This audit log does not work because it has no user id
417+
// associated with it. The audit log commitAudit() function ignores
418+
// the audit log if there is no user id.
416419
aReq, commitAudit = audit.InitRequest[database.WorkspaceProxy](rw, &audit.RequestParams{
417420
Audit: *auditor,
418421
Log: api.Logger,

0 commit comments

Comments
 (0)