fix: Remove quotes on GitSSH

kylecarbs · kylecarbs · commit dedc0776f3d0 · 2022-04-16T16:06:20.000Z
This was a bug @f0ssel found that was breaking gitssh.
diff --git a/agent/agent.go b/agent/agent.go
@@ -237,7 +237,7 @@ func (a *agent) handleSSHSession(session ssh.Session) error {
 	if err != nil {
 		return xerrors.Errorf("getting os executable: %w", err)
 	}
-	cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND="%s gitssh --"`, executablePath))
+	cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND=%s gitssh --`, executablePath))
 
 	sshPty, windowSize, isPty := session.Pty()
 	if isPty {
diff --git a/agent/agent_test.go b/agent/agent_test.go
@@ -57,7 +57,7 @@ func TestAgent(t *testing.T) {
 		}
 		output, err := session.Output(command)
 		require.NoError(t, err)
-		require.Contains(t, string(output), "gitssh --")
+		require.True(t, strings.HasSuffix(strings.TrimSpace(string(output)), "gitssh --"))
 	})
 
 	t.Run("SessionTTY", func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ func (a *agent) handleSSHSession(session ssh.Session) error {`
`237`	`237`	`if err != nil {`
`238`	`238`	`return xerrors.Errorf("getting os executable: %w", err)`
`239`	`239`	`}`
`240`		- cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND="%s gitssh --"`, executablePath))
	`240`	+ cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND=%s gitssh --`, executablePath))
`241`	`241`
`242`	`242`	`sshPty, windowSize, isPty := session.Pty()`
`243`	`243`	`if isPty {`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func TestAgent(t *testing.T) {`
`57`	`57`	`}`
`58`	`58`	`output, err := session.Output(command)`
`59`	`59`	`require.NoError(t, err)`
`60`		`- require.Contains(t, string(output), "gitssh --")`
	`60`	`+ require.True(t, strings.HasSuffix(strings.TrimSpace(string(output)), "gitssh --"))`
`61`	`61`	`})`
`62`	`62`
`63`	`63`	`t.Run("SessionTTY", func(t *testing.T) {`