refactor: remove DeterminePrebuildsState lock

evgeniy-scherbina · evgeniy-scherbina · commit e807d0265cac · 2025-04-09T12:49:33.000-04:00
diff --git a/coderd/database/lock.go b/coderd/database/lock.go
@@ -13,7 +13,6 @@ const (
 	LockIDNotificationsReportGenerator
 	LockIDCryptoKeyRotation
 	LockIDReconcileTemplatePrebuilds
-	LockIDDeterminePrebuildsState
 )
 
 // GenLockID generates a unique and consistent lock ID from a given string.
diff --git a/enterprise/coderd/prebuilds/reconcile.go b/enterprise/coderd/prebuilds/reconcile.go
@@ -230,16 +230,6 @@ func (c *StoreReconciler) SnapshotState(ctx context.Context, store database.Stor
 	var state prebuilds.GlobalSnapshot
 
 	err := store.InTx(func(db database.Store) error {
-		start := c.clock.Now()
-
-		// TODO: per-template ID lock?
-		err := db.AcquireLock(ctx, database.LockIDDeterminePrebuildsState)
-		if err != nil {
-			return xerrors.Errorf("failed to acquire state determination lock: %w", err)
-		}
-
-		c.logger.Debug(ctx, "acquired state determination lock", slog.F("acquire_wait_secs", fmt.Sprintf("%.4f", c.clock.Since(start).Seconds())))
-
 		presetsWithPrebuilds, err := db.GetTemplatePresetsWithPrebuilds(ctx, uuid.NullUUID{}) // TODO: implement template-specific reconciliations later
 		if err != nil {
 			return xerrors.Errorf("failed to get template presets with prebuilds: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ const (`
`13`	`13`	`LockIDNotificationsReportGenerator`
`14`	`14`	`LockIDCryptoKeyRotation`
`15`	`15`	`LockIDReconcileTemplatePrebuilds`
`16`		`- LockIDDeterminePrebuildsState`
`17`	`16`	`)`
`18`	`17`
`19`	`18`	`// GenLockID generates a unique and consistent lock ID from a given string.`