Apply PR suggestions

BrunoQuaresma · BrunoQuaresma · commit ebcbaa512501 · 2024-07-02T16:00:09.000Z
diff --git a/site/src/components/Filter/SelectFilter.stories.tsx b/site/src/components/Filter/SelectFilter.stories.tsx
@@ -11,7 +11,7 @@ import {
 } from "./SelectFilter";
 
 const options: SelectFilterOption[] = Array.from({ length: 50 }, (_, i) => ({
-  startIcon: <UserAvatar username={`username ${i}`} size="xs" />,
+  startIcon: <UserAvatar username={`username ${i + 1}`} size="xs" />,
   label: `Option ${i + 1}`,
   value: `option-${i + 1}`,
 }));
diff --git a/site/src/components/SelectMenu/SelectMenu.stories.tsx b/site/src/components/SelectMenu/SelectMenu.stories.tsx
@@ -1,3 +1,4 @@
+import { action } from "@storybook/addon-actions";
 import type { Meta, StoryObj } from "@storybook/react";
 import { userEvent, within } from "@storybook/test";
 import { UserAvatar } from "components/UserAvatar/UserAvatar";
@@ -109,7 +110,7 @@ export const NoSelectedOption: Story = {
           <SelectMenuButton css={{ width: 200 }}>All users</SelectMenuButton>
         </SelectMenuTrigger>
         <SelectMenuContent>
-          <SelectMenuSearch onChange={() => {}} />
+          <SelectMenuSearch onChange={action("search")} />
           <SelectMenuList>
             {opts.map((o) => (
               <SelectMenuItem key={o}>
diff --git a/site/src/pages/WorkspacesPage/filter/menus.tsx b/site/src/pages/WorkspacesPage/filter/menus.tsx
@@ -31,10 +31,7 @@ export const useTemplateFilterMenu = ({
       const template = templates.find((template) => template.name === value);
       if (template) {
         return {
-          label:
-            template.display_name !== ""
-              ? template.display_name
-              : template.name,
+          label: template.display_name || template.name,
           value: template.name,
           startIcon: <TemplateAvatar size="xs" template={template} />,
         };
