Correct dbauthz test

dannykopping · dannykopping · commit f34431b48682 · 2024-07-10T10:45:59.000Z
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -2493,7 +2493,8 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 	}))
 	s.Run("FetchNewMessageMetadata", s.Subtest(func(db database.Store, check *expects) {
 		// TODO: update this test once we have a specific role for notifications
-		check.Args(database.FetchNewMessageMetadataParams{}).Asserts(rbac.ResourceSystem, policy.ActionRead)
+		u := dbgen.User(s.T(), db, database.User{})
+		check.Args(database.FetchNewMessageMetadataParams{UserID: u.ID}).Asserts(rbac.ResourceSystem, policy.ActionRead)
 	}))
 	s.Run("GetNotificationMessagesByStatus", s.Subtest(func(db database.Store, check *expects) {
 		// TODO: update this test once we have a specific role for notifications
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -1870,7 +1870,7 @@ func (q *FakeQuerier) FetchNewMessageMetadata(ctx context.Context, arg database.
 		return database.FetchNewMessageMetadataRow{}, err
 	}
 
-	user, err := q.GetUserByID(ctx, arg.UserID)
+	user, err := q.getUserByIDNoLock(arg.UserID)
 	if err != nil {
 		return database.FetchNewMessageMetadataRow{}, xerrors.Errorf("fetch user: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -1870,7 +1870,7 @@ func (q *FakeQuerier) FetchNewMessageMetadata(ctx context.Context, arg database.`
`1870`	`1870`	`return database.FetchNewMessageMetadataRow{}, err`
`1871`	`1871`	`}`
`1872`	`1872`
`1873`		`- user, err := q.GetUserByID(ctx, arg.UserID)`
	`1873`	`+ user, err := q.getUserByIDNoLock(arg.UserID)`
`1874`	`1874`	`if err != nil {`
`1875`	`1875`	`return database.FetchNewMessageMetadataRow{}, xerrors.Errorf("fetch user: %w", err)`
`1876`	`1876`	`}`