feat(notifications): adapt tests with new labels

defelmnq · defelmnq · commit f47063b476d2 · 2024-10-03T07:59:24.000Z
diff --git a/coderd/notifications/notifications_test.go b/coderd/notifications/notifications_test.go
@@ -239,8 +239,9 @@ func TestWebhookDispatch(t *testing.T) {
 
 	// WHEN: a notification is enqueued (including arbitrary labels)
 	input := map[string]string{
-		"a": "b",
-		"c": "d",
+		"a":         "b",
+		"c":         "d",
+		"_logo_url": notifications.NotificationsDefaultLogoURL,
 	}
 	msgID, err := enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, input, "test")
 	require.NoError(t, err)
diff --git a/coderd/notifications/notifier.go b/coderd/notifications/notifier.go
@@ -25,7 +25,7 @@ import (
 )
 
 const (
-	notificationsDefaultLogoURL = "https://coder.com/coder-logo-horizontal.png"
+	NotificationsDefaultLogoURL = "https://coder.com/coder-logo-horizontal.png"
 )
 
 // notifier is a consumer of the notifications_messages queue. It dequeues messages from that table and processes them
@@ -236,7 +236,7 @@ func (n *notifier) prepare(ctx context.Context, msg database.AcquireNotification
 
 	if logoURL == "" {
 		//nolint:ineffassign // define to default value if unable to fetch one from db
-		logoURL = notificationsDefaultLogoURL
+		logoURL = NotificationsDefaultLogoURL
 	}
 
 	payload.Labels["_logo_url"] = logoURL

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ import (`
`25`	`25`	`)`
`26`	`26`
`27`	`27`	`const (`
`28`		`- notificationsDefaultLogoURL = "https://coder.com/coder-logo-horizontal.png"`
	`28`	`+ NotificationsDefaultLogoURL = "https://coder.com/coder-logo-horizontal.png"`
`29`	`29`	`)`
`30`	`30`
`31`	`31`	`// notifier is a consumer of the notifications_messages queue. It dequeues messages from that table and processes them`
`@@ -236,7 +236,7 @@ func (n *notifier) prepare(ctx context.Context, msg database.AcquireNotification`
`236`	`236`
`237`	`237`	`if logoURL == "" {`
`238`	`238`	`//nolint:ineffassign // define to default value if unable to fetch one from db`
`239`		`- logoURL = notificationsDefaultLogoURL`
	`239`	`+ logoURL = NotificationsDefaultLogoURL`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`payload.Labels["_logo_url"] = logoURL`