Allow missing mutable parameters to be specified

kylecarbs · kylecarbs · commit f58607f9658f · 2023-03-21T23:50:41.000Z
diff --git a/site/src/api/api.test.ts b/site/src/api/api.test.ts
@@ -1,11 +1,9 @@
 import axios from "axios"
 import {
   MockTemplate,
-  MockTemplateVersionParameter1,
-  MockTemplateVersionParameter2,
-  MockWorkspace,
+  MockTemplateVersionParameter1, MockWorkspace,
   MockWorkspaceBuild,
-  MockWorkspaceBuildParameter1,
+  MockWorkspaceBuildParameter1
 } from "testHelpers/entities"
 import * as api from "./api"
 import * as TypesGen from "./typesGenerated"
@@ -185,10 +183,7 @@ describe("api.ts", () => {
       jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValue([])
       jest
         .spyOn(api, "getTemplateVersionRichParameters")
-        .mockResolvedValue([
-          MockTemplateVersionParameter1,
-          { ...MockTemplateVersionParameter2, mutable: false },
-        ])
+        .mockResolvedValue([MockTemplateVersionParameter1])
 
       let error = new Error()
       try {
@@ -198,8 +193,6 @@ describe("api.ts", () => {
       }
 
       expect(error).toBeInstanceOf(api.MissingBuildParameters)
-      // Verify if the correct missing parameters are being passed
-      // It should not require immutable parameters
       expect((error as api.MissingBuildParameters).parameters).toEqual([
         MockTemplateVersionParameter1,
       ])
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -976,9 +976,7 @@ const getMissingParameters = (
   templateParameters: TypesGen.TemplateVersionParameter[],
 ) => {
   const missingParameters: TypesGen.TemplateVersionParameter[] = []
-  const requiredParameters = templateParameters.filter(
-    (p) => p.required && p.mutable,
-  )
+  const requiredParameters = templateParameters.filter((p) => p.required)
 
   for (const parameter of requiredParameters) {
     // Check if there is a new value
