fix(healthcheck): prevent infinite loop if DERP message exchange fails (#7112)

coadler · web-flow · commit f5a8a2771443 · 2023-04-13T13:46:16.000-05:00
diff --git a/coderd/healthcheck/derp.go b/coderd/healthcheck/derp.go
@@ -2,9 +2,7 @@ package healthcheck
 
 import (
 	"context"
-	"errors"
 	"fmt"
-	"io"
 	"net"
 	"net/netip"
 	"net/url"
@@ -390,9 +388,7 @@ func (*DERPNodeReport) recvData(client *derphttp.Client) (derp.ReceivedPacket, e
 	for {
 		msg, err := client.Recv()
 		if err != nil {
-			if errors.Is(err, io.EOF) {
-				return derp.ReceivedPacket{}, nil
-			}
+			return derp.ReceivedPacket{}, err
 		}
 
 		switch msg := msg.(type) {
