fix: Windows resize syscall using incorrect pointer (#1152)

kylecarbs · web-flow · commit fccd4fab9698 · 2022-04-25T14:30:57.000-05:00
Resizing of PTYs weren't working on Windows before,
but they are now!
diff --git a/pty/pty_windows.go b/pty/pty_windows.go
@@ -82,7 +82,11 @@ func (p *ptyWindows) Input() io.ReadWriter {
 }
 
 func (p *ptyWindows) Resize(cols uint16, rows uint16) error {
-	ret, _, err := procResizePseudoConsole.Call(uintptr(p.console), uintptr(cols)+(uintptr(rows)<<16))
+	// Taken from: https://github.com/microsoft/hcsshim/blob/54a5ad86808d761e3e396aff3e2022840f39f9a8/internal/winapi/zsyscall_windows.go#L144
+	ret, _, err := procResizePseudoConsole.Call(uintptr(p.console), uintptr(*((*uint32)(unsafe.Pointer(&windows.Coord{
+		X: int16(rows),
+		Y: int16(cols),
+	})))))
 	if ret != 0 {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,11 @@ func (p *ptyWindows) Input() io.ReadWriter {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`func (p *ptyWindows) Resize(cols uint16, rows uint16) error {`
`85`		`- ret, _, err := procResizePseudoConsole.Call(uintptr(p.console), uintptr(cols)+(uintptr(rows)<<16))`
	`85`	`+ // Taken from: https://github.com/microsoft/hcsshim/blob/54a5ad86808d761e3e396aff3e2022840f39f9a8/internal/winapi/zsyscall_windows.go#L144`
	`86`	`+ ret, _, err := procResizePseudoConsole.Call(uintptr(p.console), uintptr(((uint32)(unsafe.Pointer(&windows.Coord{`
	`87`	`+ X: int16(rows),`
	`88`	`+ Y: int16(cols),`
	`89`	`+ })))))`
`86`	`90`	`if ret != 0 {`
`87`	`91`	`return err`
`88`	`92`	`}`