fix: Windows resize syscall using incorrect pointer #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resizing of PTYs weren't working on Windows before, but they are now!
coadler
approved these changes
Apr 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 66.28% 66.42% +0.13%
==========================================
Files 261 263 +2
Lines 16237 16420 +183
Branches 156 156
==========================================
+ Hits 10763 10907 +144
- Misses 4361 4389 +28
- Partials 1113 1124 +11
Continue to review full report at Codecov.
|
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
Resizing of PTYs weren't working on Windows before, but they are now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resizing of PTYs weren't working on Windows before,
but they are now!