fix: add missing clause for tracking replacements (#17849)

dannykopping · dannykopping · commit fd0a84d3dd28 · 2025-05-15T13:20:43.000+02:00
We should only be tracking resource replacements during a prebuild
claim.

Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1751,7 +1751,7 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
 			})
 		}
 
-		if s.PrebuildsOrchestrator != nil {
+		if s.PrebuildsOrchestrator != nil && input.PrebuiltWorkspaceBuildStage == sdkproto.PrebuiltWorkspaceBuildStage_CLAIM {
 			// Track resource replacements, if there are any.
 			orchestrator := s.PrebuildsOrchestrator.Load()
 			if resourceReplacements := completed.GetWorkspaceBuild().GetResourceReplacements(); orchestrator != nil && len(resourceReplacements) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -1751,7 +1751,7 @@ func (s server) CompleteJob(ctx context.Context, completed proto.CompletedJob)`
`1751`	`1751`	`})`
`1752`	`1752`	`}`
`1753`	`1753`
`1754`		`- if s.PrebuildsOrchestrator != nil {`
	`1754`	`+ if s.PrebuildsOrchestrator != nil && input.PrebuiltWorkspaceBuildStage == sdkproto.PrebuiltWorkspaceBuildStage_CLAIM {`
`1755`	`1755`	`// Track resource replacements, if there are any.`
`1756`	`1756`	`orchestrator := s.PrebuildsOrchestrator.Load()`
`1757`	`1757`	`if resourceReplacements := completed.GetWorkspaceBuild().GetResourceReplacements(); orchestrator != nil && len(resourceReplacements) > 0 {`