fix: fix flashing error dialog in the create workspace page (#18180)

jaaydenh · web-flow · commit fd6981e5147f · 2025-06-02T16:55:05.000-04:00
This PR which updated react-query to 5.77.0 introduced an issue on the create workspace page where the error dialog would be briefly displayed while the page is loading. #18039 The issue is that there is a moment when `optOutQuery.isLoading` is false and `optOutQuery.data` is undefined causing the ErrorAlert to display.
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx
@@ -44,11 +44,11 @@ const CreateWorkspaceExperimentRouter: FC = () => {
 	});
 
 	if (dynamicParametersEnabled) {
-		if (optOutQuery.isLoading) {
-			return <Loader />;
+		if (optOutQuery.isError) {
+			return <ErrorAlert error={optOutQuery.error} />;
 		}
 		if (!optOutQuery.data) {
-			return <ErrorAlert error={optOutQuery.error} />;
+			return <Loader />;
 		}
 
 		const toggleOptedOut = () => {

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,11 @@ const CreateWorkspaceExperimentRouter: FC = () => {`
`44`	`44`	`});`
`45`	`45`
`46`	`46`	`if (dynamicParametersEnabled) {`
`47`		`- if (optOutQuery.isLoading) {`
`48`		`- return <Loader />;`
	`47`	`+ if (optOutQuery.isError) {`
	`48`	`+ return <ErrorAlert error={optOutQuery.error} />;`
`49`	`49`	`}`
`50`	`50`	`if (!optOutQuery.data) {`
`51`		`- return <ErrorAlert error={optOutQuery.error} />;`
	`51`	`+ return <Loader />;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`const toggleOptedOut = () => {`