Skip to content

"Promote" button is confusing when the version is already promoted. #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Oct 2, 2023 · 4 comments
Closed

"Promote" button is confusing when the version is already promoted. #10002

bpmct opened this issue Oct 2, 2023 · 4 comments
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard

Comments

@bpmct
Copy link
Member

bpmct commented Oct 2, 2023

Can we hide the promote button for the promoted version entirely? It seems like it is greyed out, but I think that's still a bit confusing

image
@bpmct bpmct added the s3 Bugs that confuse, annoy, or are purely cosmetic label Oct 2, 2023
@cdr-bot cdr-bot bot added the bug label Oct 2, 2023
@bpmct bpmct added the site Area: frontend dashboard label Oct 2, 2023
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 6, 2023
@matifali
Copy link
Member

matifali commented Nov 6, 2023 •
edited
Loading

@BrunoQuaresma #10504 could be related

@BrunoQuaresma BrunoQuaresma removed their assignment Nov 6, 2023
@BrunoQuaresma BrunoQuaresma mentioned this issue Nov 6, 2023
Closed
@aslilac
Copy link
Member

aslilac commented Nov 6, 2023

we display this intentionally, because it looks bad for it to not be there when there are multiple versions. we can tweak the styling if it would help tho.

@johnstcn
Copy link
Member

This looks like it's been fixed by #10555
image

The "promote" button now looks sufficiently greyed-out to not be confusing to my eyes.
@bpmct can we close this out?

@BrunoQuaresma
Copy link
Collaborator

I can confirm it is fixed by #10555! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aslilac @BrunoQuaresma @johnstcn @matifali @bpmct