Skip to content

External Auth: Github Callback 404 #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djarbz opened this issue Oct 4, 2023 · 4 comments · Fixed by #10044
Closed

External Auth: Github Callback 404 #10032

djarbz opened this issue Oct 4, 2023 · 4 comments · Fixed by #10044
Labels
docs Area: coder.com/docs s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@djarbz
Copy link

djarbz commented Oct 4, 2023

I am attempting to setup the Github App integration and the callback keeps returning a 404.

CODER_EXTERNAL_AUTH_0_ID=github
CODER_EXTERNAL_AUTH_0_TYPE=github
CODER_EXTERNAL_AUTH_0_CLIENT_ID=...
CODER_EXTERNAL_AUTH_0_CLIENT_SECRET=...
https://coder.example.com/gitauth/github/callback?code=...&installation_id=...&setup_action=install

I have tried changing to /externalauth and /external-auth with no luck.
I have also tried changing the callback name to primary-github as shown in the documentation.
@cdr-bot cdr-bot bot added the bug label Oct 4, 2023
@matifali
Copy link
Member

matifali commented Oct 4, 2023 •
edited
Loading

@djarbz This has yet to be released and is not included in v2.2.0. It will be available in the next release.
You can check https://coder.com/docs/v2/v2.2.0/admin/auth for current documentation.

cc; @kylecarbs, @bpmct and @BrunoQuaresma
We should not show the latest docs but the docs from the last released version by default. Also, there should be an easy way to switch to previous versions of docs.

@matifali matifali added docs Area: coder.com/docs s3 Bugs that confuse, annoy, or are purely cosmetic labels Oct 4, 2023
@djarbz
Copy link
Author

djarbz commented Oct 4, 2023

Thank you for the quick response, that makes sense.

I would agree that showing the latest release docs by default would be helpful.

I didn't even think of checking if it was released or not as it seemed to be referenced elsewhere that made me believe it has been released for a while. Can't remember where exactly, I was looking through a lot of documentation last night.

@kylecarbs
Copy link
Member

Yeah, I'm going to revert my docs change and leave it in a PR for now until release...

@kylecarbs
Copy link
Member

kylecarbs commented Oct 4, 2023 •
edited by matifali
Loading

fixed in #10044

@matifali matifali closed this as completed Oct 6, 2023
@matifali matifali mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Area: coder.com/docs s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revert docs for git-auth until release coder/coder
3 participants
@kylecarbs @matifali @djarbz