Skip to content

flake: TestWorkspaceAgent/Timeout #10167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spikecurtis opened this issue Oct 10, 2023 · 0 comments · Fixed by #10170
Closed

flake: TestWorkspaceAgent/Timeout #10167

spikecurtis opened this issue Oct 10, 2023 · 0 comments · Fixed by #10170
Assignees

Comments

@spikecurtis
Copy link
Contributor

Looks like a spurious error on shutdown.

t.go:84: 2023-10-10 10:56:05.928 [info]  provisionerd: attempting graceful shutdown
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: sending acquire job cancel
    t.go:84: 2023-10-10 10:56:05.928 [debu]  acquirer: acquiring job canceled  worker_id=1e751b62-0b7c-4bca-a6b2-dd97d5c0fcb7  provisioner_types="[echo terraform]"  tags={"scope":"organization"}  error="context canceled"
    t.go:84: 2023-10-10 10:56:05.928 [debu]  inmem-provisionerd-brave_lumiere4: successful cancel
    t.go:84: 2023-10-10 10:56:05.928 [debu]  inmem-provisionerd-brave_lumiere4: closed stream  error=<nil>
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: graceful acquire done  job_id=""  error=<nil>
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: acquire job successfully canceled
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: exiting acquire; provisionerd is shutting down
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: acquire loop exited
    t.go:84: 2023-10-10 10:56:05.928 [info]  provisionerd: gracefully shutdown
    t.go:84: 2023-10-10 10:56:05.928 [info]  provisionerd: closing provisionerd
    t.go:84: 2023-10-10 10:56:05.928 [debu]  provisionerd: waiting for goroutines to exit
    t.go:84: 2023-10-10 10:56:05.929 [debu]  provisionerd: connect loop exited
    t.go:84: 2023-10-10 10:56:05.929 [debu]  provisionerd: closing server with error  error=<nil>
    t.go:84: 2023-10-10 10:56:05.929 [debu]  inmem-provisionerd-brave_lumiere4: drpc server error ...
        error= context canceled
               	storj.io/drpc/drpcserver.(*Server).ServeOne:64
               	storj.io/drpc/drpcserver.(*Server).Serve.func2:114
               	storj.io/drpc/drpcctx.(*Tracker).track:35
    t.go:84: 2023-10-10 10:56:05.929 [info]  inmem-provisionerd-brave_lumiere4: provisioner daemon disconnected  error=<nil>
    t.go:84: 2023-10-10 10:56:05.929 [debu]  workspaceapps.stats_collector: flushing workspace app stats
    t.go:84: 2023-10-10 10:56:05.929 [debu]  workspaceapps.stats_collector: flushed workspace app stats
    t.go:84: 2023-10-10 10:56:05.929 [debu]  workspaceapps.stats_collector: workspace app stats collector stopped
    stuntest.go:63: STUN server shutdown
    t.go:93: 2023-10-10 10:56:05.931 [erro]  inmem-provisionerd-brave_lumiere4: workspace notification after agent timeout failed  workspace_build_id=e00127f0-a1f7-4b01-b76e-ed530148f[410](https://github.com/coder/coder/runs/17560024184#step:5:411) ...
        error= exec pg_notify:
                   github.com/coder/coder/v2/coderd/database/pubsub.(*pgPubsub).Publish
                       /home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub/pubsub.go:235
                 - context canceled
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

seen at https://github.com/coder/coder/runs/17560024184

@spikecurtis spikecurtis self-assigned this Oct 10, 2023
@cdr-bot cdr-bot bot added the chore label Oct 10, 2023
spikecurtis added a commit that referenced this issue Oct 10, 2023
fixes #10167

Annoyingly, there isn't a good way to stop the publish from being sent on shutdown, and subscribing to them in the test is too fragile because empty messages are sent in a bunch of places, so we can't reliably tell it's regarding timeouts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant