Skip to content

flake: SSHKeyPage.test.tsx has too many element matches #10481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parkreiner opened this issue Nov 1, 2023 · 1 comment · Fixed by #10553
Closed

flake: SSHKeyPage.test.tsx has too many element matches #10481

Parkreiner opened this issue Nov 1, 2023 · 1 comment · Fixed by #10553
Assignees
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks site Area: frontend dashboard

Comments

@Parkreiner
Copy link
Member

Parkreiner commented Nov 1, 2023

Had this happen earlier today, but for some reason, I can't find the logs in the actions that ran. Not sure if re-running the test caused the logs to get wiped.

Either way, there's an issue that sometimes triggers on SSHKeyPage.test.tsx. Here's a failing run

Here's what looks like the most important part:

Found multiple elements with the text: Error regenerating SSH key

From looking at the rest of the tests, it looks like there's a conflict between the error surfaced in the main part of the UI, and the little toast/snackbar UI we have for more global messages. Two things come to mind here:

  1. Update the test to be more specific and always grab the correct element
  2. Look into why the global snackbar only sometimes gets dismissed

Hoping to look into this either Thursday or Friday this week.

@Parkreiner Parkreiner added site Area: frontend dashboard flake labels Nov 1, 2023
@Parkreiner Parkreiner self-assigned this Nov 1, 2023
@cdr-bot cdr-bot bot added the chore label Nov 1, 2023
@matifali matifali added bug s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks and removed chore labels Nov 3, 2023
@Parkreiner
Copy link
Member Author

Marking this as blocked for the moment

The PR is done and approved – it's just that with the Storybook issues that suddenly started today, I want to make sure that pushing in the code won't break unrelated stories further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants