Skip to content

Add Agent API v2 websocket endpoint #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Nov 6, 2023 · 0 comments · Fixed by #11696
Closed

Add Agent API v2 websocket endpoint #10531

spikecurtis opened this issue Nov 6, 2023 · 0 comments · Fixed by #11696
Labels
networking Area: networking

Comments

@spikecurtis
Copy link
Contributor

After the Agent v2 API is supported in Coderd (#10530), add a websocket endpoint to allow an agent to connect.
@cdr-bot cdr-bot bot added the feature label Nov 6, 2023
@spikecurtis spikecurtis mentioned this issue Nov 6, 2023
Closed
@spikecurtis spikecurtis added the networking Area: networking label Nov 6, 2023
@spikecurtis spikecurtis mentioned this issue Dec 21, 2023
Merged
spikecurtis added a commit that referenced this issue Jan 2, 2024
@spikecurtis
feat: add tailnet to agent RPC service (#11304)
36636bb 
Adds tailnet.DRPCService to the agent API

Supports #10531 but we still need to add version negotiation to the websocket endpoint
@spikecurtis spikecurtis mentioned this issue Jan 22, 2024
Merged
spikecurtis added a commit that referenced this issue Jan 23, 2024
@spikecurtis
feat: check agent API version on connection (#11696)
3e0e7f8 
fixes #10531

Adds a check for `version` on connection to the Agent API websocket endpoint.  This is primarily for future-proofing, so that up-level agents get a sensible error if they connect to a back-level Coderd.

It also refactors the location of the `CurrentVersion` variables, to be part of the `proto` packages, since the versions refer to the APIs defined therein.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
networking Area: networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check agent API version on connection coder/coder
1 participant
@spikecurtis