Skip to content

bug: After correcting a duplicate workspace name, the validation errors remain #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharkymark opened this issue Nov 13, 2023 · 2 comments · Fixed by #10927
Closed

bug: After correcting a duplicate workspace name, the validation errors remain #10637

sharkymark opened this issue Nov 13, 2023 · 2 comments · Fixed by #10927
Assignees
@Kira-Pilot
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@sharkymark
Copy link
Contributor

Version: v2.3.3+e491217

Coder correctly checks if a duplicate workspace name is chosen at workspace creation.

However, if I change the name, the red errors still appear, but if I press create, the workspace creates fine.

image
@cdr-bot cdr-bot bot added the bug label Nov 13, 2023
@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Nov 14, 2023
@matifali
Copy link
Member

This is because we do not recheck the field before we press the create button. @BrunoQuaresma, please correct me if I am wrong.

@BrunoQuaresma
Copy link
Collaborator

@matifali you are 100% right

@Kira-Pilot Kira-Pilot mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clear workspace name validation on field dirty coder/coder
4 participants
@sharkymark @BrunoQuaresma @matifali @Kira-Pilot