Skip to content

Remove swr #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greyscaled opened this issue Apr 19, 2022 · 2 comments · Fixed by #3495
Closed

Remove swr #1082

greyscaled opened this issue Apr 19, 2022 · 2 comments · Fixed by #3495
Labels
site Area: frontend dashboard

Comments

@greyscaled
Copy link
Contributor

greyscaled commented Apr 19, 2022 •
edited by presleyp
Loading

Problem

Initially, v2 used the swr library, but then we moved away from it. However, it's still installed and we may have some code related to it. This is tech debt, and it's good to have as few dependencies as possible.

Definition of Done

swr is uninstalled and there is no dead code related to it.

Related

There was a related TODO comment in removed in #1066
@greyscaled greyscaled mentioned this issue Apr 19, 2022
Merged
@misskniss misskniss added site Area: frontend dashboard needs grooming 🪒 labels Apr 26, 2022
@misskniss misskniss added this to the Community MVP milestone Apr 26, 2022
@misskniss
Copy link

This is a nice to have for community that @BrunoQuaresma can look into for us. Not customer facing.

@kylecarbs kylecarbs changed the title Chore: Remove swr Remove swr Jun 7, 2022
@misskniss misskniss removed this from the Enterprise MVP milestone Jul 22, 2022
@f0ssel f0ssel mentioned this issue Jul 28, 2022
Closed
@bpmct
Copy link
Member

bpmct commented Aug 1, 2022

@presleyp @BrunoQuaresma I noticed this was in enqueue. could add a problem statement and def. of done? I'm not sure about the context here.

Would also appreciate your thoughts on the priority (I'd imagine debt-related) and estimate.

@oxy oxy mentioned this issue Aug 12, 2022
Merged
@oxy oxy closed this as completed in #3495 Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove swr and dead code coder/coder
6 participants
@presleyp @misskniss @BrunoQuaresma @kylecarbs @greyscaled @bpmct