Skip to content

Display github login configuration on the /deployment page #10865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Nov 25, 2023 · 4 comments · Fixed by #11488
Closed

Display github login configuration on the /deployment page #10865

matifali opened this issue Nov 25, 2023 · 4 comments · Fixed by #11488
Assignees
@BrunoQuaresma
Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard

Comments

@matifali
Copy link
Member

matifali commented Nov 25, 2023 •
edited
Loading

We already show the OIDC sign-in configuration on the /deployment/userauth page. We also show if GitHub sign-in is configured. It would be nice to see the allowed GitHub organizations and if signups are allowed on this page.

image
We are currently showing no options to configure, which is wrong as we do have the configuration for GitHub.

CODER_OAUTH2_GITHUB_ALLOW_SIGNUPS=true.                           # show this
CODER_OAUTH2_GITHUB_ALLOWED_ORGS="org1,org2"                      # show this
CODER_OAUTH2_GITHUB_CLIENT_ID="XXXXXXXXX"                         # show this
CODER_OAUTH2_GITHUB_CLIENT_SECRET="YYYYYYYYYYYYYYYYYYYYYYYYYYYYY" # do not show
@matifali matifali added feature site Area: frontend dashboard good first issue Easily solved issues suitable for starters and community contributors labels Nov 25, 2023
@matifali matifali changed the title Display github allowed organizations on the /deployment page Display github login configuration on the /deployment page Nov 25, 2023
@Teja-11
Copy link

Teja-11 commented Nov 26, 2023

Can i work on this?

@matifali
Copy link
Member Author

@Teja-11 yes sure. You are welcome to contribute.

@mtojek
Copy link
Member

mtojek commented Jan 8, 2024

hey @BrunoQuaresma Is it site-only issue or do you need a backend hand here?

@BrunoQuaresma
Copy link
Collaborator

It is site only 👍

@BrunoQuaresma BrunoQuaresma mentioned this issue Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): display github login config coder/coder
4 participants
@BrunoQuaresma @matifali @mtojek @Teja-11