Skip to content

disabling auto-start & stop fields at the template level does not update workspace fields #10930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #11503
ericpaulsen opened this issue Nov 29, 2023 · 6 comments · Fixed by #11809
Closed
Tracked by #11503

disabling auto-start & stop fields at the template level does not update workspace fields #10930

ericpaulsen opened this issue Nov 29, 2023 · 6 comments · Fixed by #11809
Assignees
@Kira-Pilot
Labels
site Area: frontend dashboard

Comments

@ericpaulsen
Copy link
Member

#10022 disables the input fields, but does not turn off the auto-start or auto-stop once it is disabled at the template level. here is an example, where i have a workspace with both auto-start and stop enabled, but disabled at the template level:

Screenshot 2023-11-28 at 16 04 14
@ericpaulsen ericpaulsen added site Area: frontend dashboard bug labels Nov 29, 2023
@ericpaulsen ericpaulsen mentioned this issue Nov 29, 2023
Closed
@BrunoQuaresma
Copy link
Collaborator

I think this is not a FE issue. Ideally, when the template changes its settings, the BE should update the related workspaces to match the new config.

@BrunoQuaresma BrunoQuaresma assigned sreya and unassigned BrunoQuaresma Nov 29, 2023
@BrunoQuaresma
Copy link
Collaborator

Since it is related to scheduling, I think @sreya is a better person to handle it 🙏

@Kira-Pilot
Copy link
Member

Similar to #10636

@ericpaulsen
Copy link
Member Author

@BrunoQuaresma I disagree, the front-end issue is that the input fields are still selectable and editable, despite the autostart/stop & stop being disabled at the template level.

the expected behavior should be: if autostart/stop is disabled at the template level, then the Enable Autostart/stop toggles are switched off, to prevent field editing.

@bpmct bpmct assigned Kira-Pilot and unassigned sreya Dec 20, 2023
@bpmct
Copy link
Member

bpmct commented Dec 20, 2023

We'll be able to get to this first thing in January!

@bpmct
Copy link
Member

bpmct commented Dec 20, 2023

The way this is described gives the admin the impression that it limits the days all workspaces can be autostarted. The desired behavior from our customers is that it does this as well

Screenshot 2023-12-20 at 9 39 39 AM

@stirby stirby mentioned this issue Jan 8, 2024
Closed
13 tasks
@Kira-Pilot Kira-Pilot mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): disable autostart and autostop according to template settings coder/coder
5 participants
@BrunoQuaresma @sreya @ericpaulsen @Kira-Pilot @bpmct