Skip to content

flake: TestAgent_WriteVSCodeConfigs #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Dec 15, 2023 · 1 comment · Fixed by #11243
Closed

flake: TestAgent_WriteVSCodeConfigs #11226

spikecurtis opened this issue Dec 15, 2023 · 1 comment · Fixed by #11243
Assignees
@Emyrk
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@spikecurtis
Copy link
Contributor

https://github.com/coder/coder/runs/19666833200

Test times out after 10 minutes due to a deadlock in shutting down the agent

goroutine 2555 [semacquire, 9 minutes]:
sync.runtime_Semacquire(0xc0006ae1b0?)
	/opt/hostedtoolcache/go/1.21.5/x64/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc0006ae1a8)
	/opt/hostedtoolcache/go/1.21.5/x64/src/sync/waitgroup.go:116 +0xa5
github.com/coder/coder/v2/agent/agentscripts.(*Runner).Close(0xc0006ae100)
	/home/runner/actions-runner/_work/coder/coder/agent/agentscripts/agentscripts.go:320 +0x19e
github.com/coder/coder/v2/agent.(*agent).Close(0xc004a0b200)
	/home/runner/actions-runner/_work/coder/coder/agent/agent.go:1498 +0x439
github.com/coder/coder/v2/agent_test.TestAgent_WriteVSCodeConfigs(0xc005b456c0)
	/home/runner/actions-runner/_work/coder/coder/agent/agent_test.go:1870 +0x160a
testing.tRunner(0xc005b456c0, 0x27ceba0)
	/opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1595 +0x262
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1648 +0x846
@spikecurtis spikecurtis added flake s3 Bugs that confuse, annoy, or are purely cosmetic labels Dec 15, 2023
@cdr-bot cdr-bot bot added the bug label Dec 15, 2023
@Emyrk Emyrk mentioned this issue Dec 15, 2023
Merged
@Emyrk
Copy link
Member

Emyrk commented Dec 15, 2023

this unit test exercises the bug: 2782521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix race in cron close behavior (TestAgent_WriteVSCodeConfigs) coder/coder
2 participants
@spikecurtis @Emyrk