Skip to content

log spam CRITICAL failed to convert node #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Dec 19, 2023 · 0 comments · Fixed by #11277
Closed

log spam CRITICAL failed to convert node #11276

spikecurtis opened this issue Dec 19, 2023 · 0 comments · Fixed by #11277
Assignees
@spikecurtis
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@spikecurtis
Copy link
Contributor

Customers are seeing logs dropped from this line:

coder/enterprise/tailnet/pgcoord.go

Line 190 in 83e1349

c.logger.Critical(c.ctx, "failed to convert node", slog.F("node", bestN), slog.Error(err))

like

2023-12-19 02:01:06.578 [crit]  coderd.pgcoord: failed to convert node  coordinator_id=b830df01-161b-49ca-9003-9b4b23d0e50f  node=<nil>  error="missing/incorrect type prefix np"

We are missing a check for the node being missing (allowed by this function) before trying to convert it.

Since the correct behavior is to return nil (and NOT drop a log), the only problem is the log itself.
@spikecurtis spikecurtis added s3 Bugs that confuse, annoy, or are purely cosmetic bug labels Dec 19, 2023
@spikecurtis spikecurtis self-assigned this Dec 19, 2023
@spikecurtis spikecurtis mentioned this issue Dec 19, 2023
Merged
spikecurtis added a commit that referenced this issue Dec 19, 2023
@spikecurtis
fix: avoid converting nil node
f2606a7 
fixes: #11276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid converting nil node coder/coder
1 participant
@spikecurtis