-
Notifications
You must be signed in to change notification settings - Fork 886
bug: Logo URL in Appearance dashboard does not explain that it also updates the logo on the Sign In page #11345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What do you suggest as the solution? Improve the wording or suport separate logos for both places? |
The helper text needs to mention this name also updates the sign in page The second issue is a bug I think - if you want to test. Changing that text did nothing to my sign in page. |
Went ahead and made a fix for the wording in #11377. I can look at the Application Name issue if product believes this is a bug but unfamiliar with the decisions and changes when they were made so I don't want to jump to conclusions that something needs fixing there. |
So I looked into this further and the application name is only used on the frontend to provide an This means the Application Name would only be displayed if the image failed to load or if the user is using a screenreader. This code looks pretty intentional, so I'm going to assume it isn't a bug but that the wording under this field is also slightly confusing. So I propose:
I probably am not the best at the design change part but can implement whatever the frontend team would like to do. |
Just to take into consideration: A few customers shared that they found the old heading "Sign in to Company Name" quite overwhelming and I kinda agree with that. That was the reason why I simplified it in the last sign-in page refactoring. We should improve the settings page where the user can upload the logo and let the user decide what they want to do:
|
@BrunoQuaresma Do you think those same companies would fine the default "Sign in to Coder" overwhelming? I can see why someone setting it to "CartoonNetwork" might find "Sign in to CartoonNetwork" confusing, but I feel like the default should be sane enough to not need another toggle switch IMO. |
@f0ssel yeap, I'm going to share it with you privately. |
I went ahead and made a PR #11500 to display just the application name here instead. @sharkymark @matifali @BrunoQuaresma Please let me know if you think this makes sense and would please our current clients. Thanks! |
The help text for the Logo URL in Appearance dashboard does not correctly explain that it also updates the logo at the top of the Sign In page. It does update the logo at the top left of the main dashboard too.
This a second issue, but changing the Application Name in the Appearance dashboard does not change anything on the Sign In page.
The text was updated successfully, but these errors were encountered: