Skip to content

Hide DERP tags on the health page if they are false #11417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrunoQuaresma opened this issue Jan 4, 2024 — with Slack · 3 comments · Fixed by #11439
Closed

Hide DERP tags on the health page if they are false #11417

BrunoQuaresma opened this issue Jan 4, 2024 — with Slack · 3 comments · Fixed by #11439
Assignees
@BrunoQuaresma
Labels
site Area: frontend dashboard

Comments

@BrunoQuaresma Slack
Copy link
Collaborator

Some feedback, the red pills such as DERP Only and Disabled make it look like something is wrong. Thoughts on just hiding them if the value is false?

Slack Message
@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Jan 4, 2024 — with Slack
@cdr-bot cdr-bot bot added the feature label Jan 4, 2024
@matifali matifali changed the title Hide DERP tags on health page if they are false Hide DERP tags on the health page if they are false Jan 4, 2024
@spikecurtis
Copy link
Contributor

I think it's ok to hide DERP Only if it's false. My assumption is the default will be DERP + app proxy for most users.

I don't see Disabled on the page, so maybe this is referring to Deleted? We soft-delete workspace proxies, so any proxy that is deleted should not be shown at all on the health page.

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 5, 2024
@BrunoQuaresma
Copy link
Collaborator Author

@johnstcn maybe we should update the backend to only return WS Proxies that are not deleted?

@BrunoQuaresma BrunoQuaresma mentioned this issue Jan 5, 2024
Merged
@johnstcn johnstcn mentioned this issue Jan 5, 2024
Closed
@johnstcn
Copy link
Member

johnstcn commented Jan 5, 2024

@johnstcn maybe we should update the backend to only return WS Proxies that are not deleted?

Filed #11440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(site): only show derp tags if they are true coder/coder
3 participants
@BrunoQuaresma @johnstcn @spikecurtis