Skip to content

add the storybook interactions add-on and accessibility add-on #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kira-Pilot opened this issue Jan 4, 2024 · 2 comments
Closed

add the storybook interactions add-on and accessibility add-on #11422

Kira-Pilot opened this issue Jan 4, 2024 · 2 comments
Assignees
@aslilac
Milestone
Code Stability

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jan 4, 2024 •
edited by Parkreiner
Loading

We are interested in adding the storybook interactions add-on to our FE as a possible replacement for jest testing. We should try this out and write a couple of tests as a POC.

Additionally we want to try out the storybook accessibility add-on, so we should add this as well, along with a couple of tests. In the past it was uncertain if this was playing nicely with Chromatic so this should be part of the discovery work.
@Kira-Pilot Kira-Pilot added this to the FE Code Stability milestone Jan 4, 2024
@Kira-Pilot Kira-Pilot changed the title add the storybook interactions add-on add the storybook interactions add-on and accessibility add-on Jan 4, 2024
@sreya sreya assigned sreya and aslilac and unassigned sreya Jan 29, 2024
@aslilac aslilac mentioned this issue Jan 29, 2024
Merged
@aslilac
Copy link
Member

aslilac commented Jan 30, 2024

I think my impression so far is that:

  • Interaction testing is a huge yes. It's just the jest/puppeteer testing that we're already doing but better.

  • Accessibility testing does seem like we'd win much. It mostly just yells about alt props, which we already have a lint rule for, and which we explicitly choose to not use sometimes, in favor of visuallyHidden.

@aslilac
Copy link
Member

aslilac commented Feb 5, 2024

We're going to keep the accessibility addon on our radar, but the Chromatic integration is lacking, and it doesn't seem like much of a win right now. The interactions addon has been added and seems good!

@aslilac aslilac closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
Code Stability
Development

No branches or pull requests
3 participants
@aslilac @sreya @Kira-Pilot