-
Notifications
You must be signed in to change notification settings - Fork 881
coder_parameter doesn't support monotonic for option values #11579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @mattlqx do you have any issues while setting it. O think it should work of you also set the @mtojek don't we support |
The problem seems to be actually that
That's with the following attributes:
|
We should definitely support monotonic type validation for options with type number. cc: @coder/pms @mtojek |
I second what Matt said about the problem. Coder enables validation for number fields, but since there are options provided, it assumes that it does not need advanced validation. Hence there is a type conflict. It is aligned with the initial design of Coder parameters which assumed that parameter options are only strings. This issue is kind of a whack-a-mole challenge. Fix all places, hopefully only in Coder, until it works correctly. |
Would it be possible to support
monotonic
validation on parameters that use options that have numeric values?I have a 3 volume size options on my template. Sizes can't be effectively reduced. It would be nice if the setting could be validated so that selecting a smaller one than current would fail validation. e.g.
I would like it to also support the block:
The text was updated successfully, but these errors were encountered: