Skip to content

Feature: Support ZIP files to upload/download templates #11687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrunoQuaresma opened this issue Jan 18, 2024 · 7 comments
Closed

Feature: Support ZIP files to upload/download templates #11687

BrunoQuaresma opened this issue Jan 18, 2024 · 7 comments
Assignees
Labels
site Area: frontend dashboard

Comments

@BrunoQuaresma
Copy link
Collaborator

  • Better support on JS libraries than writing our own tar library
  • Maybe a better experience for Mac and windows since those support Zip natively
@MrPeacockNLB
Copy link
Contributor

MrPeacockNLB commented Jan 19, 2024

Thinking about this feature we may consider that it may be useful to protect this via RBAC role as template sources as well.

@mtojek mtojek self-assigned this Jan 26, 2024
@mtojek
Copy link
Member

mtojek commented Jan 26, 2024

I like this idea, so I'm going to review what we should do to support .zip files.

EDIT:

Let's start with ensuring backward compatibility, so:

@mtojek
Copy link
Member

mtojek commented Jan 31, 2024

@BrunoQuaresma I think that you can try to experiment with .zip files. Upload API accepts it, but to download a .zip, you can to append query param ?format=zip.

@BrunoQuaresma
Copy link
Collaborator Author

That is awesome. Ty!

@mtojek
Copy link
Member

mtojek commented Feb 4, 2024

@BrunoQuaresma Did you find some time to play with it?

@mtojek
Copy link
Member

mtojek commented Feb 9, 2024

Moving to Blocked until we have FE capacity to follow up with it.

@mtojek mtojek removed their assignment Feb 15, 2024
@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Feb 22, 2024
@BrunoQuaresma
Copy link
Collaborator Author

Zip upload is supported by the UI now. I need to evaluate changing the template editor to use zip more carefully since this part of the code is a bit fragile at the moment.

#12346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

3 participants