-
Notifications
You must be signed in to change notification settings - Fork 881
Workspace list shows nothing if page number is too big #11795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm wondering if a user accesses a page that does not exist anymore, it should get redirected to the first page or just display a not found message. |
That's a very good question. I'm kind of partial to letting the user choose, i.e. no 404 and no redirect. In my fantasy, we'd show a tooltip/banner that this page doesn't exist, but we'd still show the page 85 button as selected, with the ability to select a previous page (that exists). Does that make sense? |
I think I got an idea for a good fix. Thanks for the reply! |
When requesting to the BE a page that does not exist, like {"workspaces":[],"count":0} I think this could return a |
Going to unassign this for now since we would need some BE fix first. |
cc @mtojek |
Looking into this |
@BrunoQuaresma Backend changes are merged. Workspace Passing the ball to you to finish frontend changes. |
Page 85 existed while I was batch deleting workspaces. Then after all operations were complete, the page no longer existed and the workspace list "broke", as in, shows that there is nothing and no pagination.
https://big.cdr.dev/workspaces?filter=&page=85
:The text was updated successfully, but these errors were encountered: