Skip to content

exp/scaletest: add configurable retry during workspace creation #11801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Jan 24, 2024 · 2 comments
Closed

exp/scaletest: add configurable retry during workspace creation #11801

johnstcn opened this issue Jan 24, 2024 · 2 comments
Assignees
@mafredri
Labels
scaletest Issues related to scale testing.

Comments

@johnstcn
Copy link
Member

Workspace creation may fail for various reasons. Add a configurable retry option to scaletest workspace creation that will retry the build up to N times before marking the test as failed.

cc @mafredri
@johnstcn johnstcn added scaletest Issues related to scale testing. s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Jan 24, 2024
@cdr-bot cdr-bot bot added bug labels Jan 24, 2024
@johnstcn johnstcn removed the bug label Jan 24, 2024
@cdr-bot cdr-bot bot added the bug label Jan 24, 2024
@johnstcn johnstcn removed bug s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Jan 24, 2024
@mafredri
Copy link
Member

👍🏻

In addition, I was thinking we would also add a "make sure exactly this many workspaces exist based on this template". This will help if creation fails mid-way irrespective of the retry, consecutive runs don't need to change anything.

@mafredri mafredri mentioned this issue Jan 26, 2024
Merged
mafredri added a commit that referenced this issue Jan 26, 2024
@mafredri
feat(cli/exp): extend scaletest create-workspaces with --retry option (…
0212475 
…#11825)

Part of #11801
@mafredri
Copy link
Member

In addition, I was thinking we would also add a "make sure exactly this many workspaces exist based on this template". This will help if creation fails mid-way irrespective of the retry, consecutive runs don't need to change anything.

With retry, this is actually less important IMO, so we can punt this until there's a more concrete need. Marking this as fixed by #11825.

@mafredri mafredri self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
scaletest Issues related to scale testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mafredri @johnstcn