Skip to content

shared ports: cleanup shared ports on template max share level change #12236

Closed
@f0ssel

Description

@f0ssel
No description provided.

Activity

self-assigned this
on Feb 20, 2024
stirby

stirby commented on Feb 27, 2024

@stirby
Collaborator

I did notice the following behavior:

  • Max template sharing level is public
  • Have process on port 3000 on workspace X
  • share port as public
  • reduce max sharing level in template
  • the dropdown UI is updated, but the port is still shared as public

I assume issue seeks to address strict enforcement of the template sharing level?

f0ssel

f0ssel commented on Mar 4, 2024

@f0ssel
ContributorAuthor

Exactly, any shared ports based on that template that are above the new sharing level will be reduced down to the new level. This ensures that revoking access at the template level immediately goes into effect for all workspaces based on it.

f0ssel

f0ssel commented on Mar 4, 2024

@f0ssel
ContributorAuthor

This also means that when the level is reduced to owner that all the shared ports will be deleted. I think this is better than trying to show some representation of a "public" shared port that is disabled because of the template level - just seemed too complicated to explain to the user IMO.

stirby

stirby commented on Mar 5, 2024

@stirby
Collaborator

Sounds great - Totally agree on deleting the shared ports when an admin reduces the max level to owner.

Can we add a note or disclaimer that when the admin reduces it? Something as simple as "Reducing max share level to owner will remove shared ports on workspaces using this template."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    shared ports: cleanup shared ports on template max share level change · Issue #12236 · coder/coder