Skip to content

chore: Evaluate replace .tar library on FE to use ZIPJS #12346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrunoQuaresma opened this issue Feb 28, 2024 · 3 comments
Closed

chore: Evaluate replace .tar library on FE to use ZIPJS #12346

BrunoQuaresma opened this issue Feb 28, 2024 · 3 comments
Assignees
@BrunoQuaresma
Labels
site Area: frontend dashboard

Comments

@BrunoQuaresma
Copy link
Collaborator

The idea is to make our file handling more reliable using a well-supported zip library rather than writing and maintaining our own.
@BrunoQuaresma BrunoQuaresma added site Area: frontend dashboard chore labels Feb 28, 2024
@BrunoQuaresma BrunoQuaresma self-assigned this Feb 28, 2024
@BrunoQuaresma BrunoQuaresma mentioned this issue Feb 28, 2024
Closed
@mtojek
Copy link
Member

mtojek commented Feb 28, 2024

@BrunoQuaresma Remember that we do not drop support for .tar entirely. It would be great to discuss the next steps with product. cc @bpmct

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Feb 28, 2024 •
edited
Loading

Yes, I'm aware of that. Since it is an internal thing, what library to use, and how we want to maintain the code on the template editor, I think it is more an engineering decision than a product this is why I labeled it as chore.

@BrunoQuaresma
Copy link
Collaborator Author

I think we can ignore this for now since what we have is stable enough and I would avoid introducing changes without a good reason to.

@BrunoQuaresma BrunoQuaresma closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrunoQuaresma @mtojek