Skip to content

flake: multiple TestWorkspaceProxyWorkspaceApps/* flakes #12531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Mar 11, 2024 · 7 comments
Closed

flake: multiple TestWorkspaceProxyWorkspaceApps/* flakes #12531

johnstcn opened this issue Mar 11, 2024 · 7 comments
Assignees
@Emyrk
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@johnstcn
Copy link
Member

Seen here: https://github.com/coder/coder/actions/runs/8233181037/job/22512128222?pr=12515

=== Failed
=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxySubdomain/ProxyError (0.07s)
    apptest.go:921: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:921
        	Error:      	Not equal: 
        	            	expected: 502
        	            	actual  : 200
        	Test:       	TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxySubdomain/ProxyError

=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxyPath/ProxyError (0.00s)
    apptest.go:382: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:382
        	Error:      	Not equal: 
        	            	expected: 502
        	            	actual  : 200
        	Test:       	TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxyPath/ProxyError

=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxySubdomain (1.63s)
@johnstcn johnstcn added flake s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Mar 11, 2024
@dannykopping
Copy link
Contributor

Also saw these in https://github.com/coder/coder/actions/runs/8251597743/job/22569038030?pr=12559:

=== Failed
=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/NoProxyPort (10.00s)
    apptest.go:400: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:1727
        	            				/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:400
        	Error:      	Condition never satisfied
        	Test:       	TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/NoProxyPort
        	Messages:   	workspace LastUsedAt not updated when it should have been

=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/LoginWithoutAuthOnProxy (10.03s)
    apptest.go:189: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:1727
        	            				/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:189
        	Error:      	Condition never satisfied
        	Test:       	TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/LoginWithoutAuthOnProxy
        	Messages:   	workspace LastUsedAt not updated when it should have been

I've expanded the scope of the issue to encompass multiple TestWorkspaceProxyWorkspaceApps flakes.

@dannykopping dannykopping changed the title flake: TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxySubdomain/ProxyError flake: multiple TestWorkspaceProxyWorkspaceApps/* flakes Mar 13, 2024
@spikecurtis
Copy link
Contributor

I'm also seeing this: https://github.com/coder/coder/runs/22597523247

@Emyrk Emyrk mentioned this issue Mar 13, 2024
Merged
@Emyrk
Copy link
Member

Emyrk commented Mar 13, 2024

Also saw these in https://github.com/coder/coder/actions/runs/8251597743/job/22569038030?pr=12559:

=== Failed
=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/NoProxyPort (10.00s)
    apptest.go:400: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:1727
        	            				/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:400
        	Error:      	Condition never satisfied
        	Test:       	TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/NoProxyPort
        	Messages:   	workspace LastUsedAt not updated when it should have been

=== FAIL: enterprise/wsproxy TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/LoginWithoutAuthOnProxy (10.03s)
    apptest.go:189: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:1727
        	            				/Users/runner/work/coder/coder/coderd/workspaceapps/apptest/apptest.go:189
        	Error:      	Condition never satisfied
        	Test:       	TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/LoginWithoutAuthOnProxy
        	Messages:   	workspace LastUsedAt not updated when it should have been

I've expanded the scope of the issue to encompass multiple TestWorkspaceProxyWorkspaceApps flakes.

This one is still unsolved. The other 2 I fixed in #12580

@Emyrk
Copy link
Member

Emyrk commented Apr 29, 2024

I am going to close this as a subset was definitely fixed. The remaining might still exist, and can be reopened.

@Emyrk Emyrk closed this as completed Apr 29, 2024
@dannykopping
Copy link
Contributor

Flakes seem to have reappeared in https://github.com/coder/coder/actions/runs/10629250399/job/29465715027?pr=14478, although they seem to be different now.

Shall I reopen this or open a new one @Emyrk?

@Emyrk
Copy link
Member

Emyrk commented Aug 30, 2024

@dannykopping I have not seen it happen in a bit iirc

@dannykopping
Copy link
Contributor

Another datapoint: https://github.com/coder/coder/actions/runs/10680634527/job/29602814387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dannykopping @johnstcn @spikecurtis @Emyrk