Skip to content

Coder's /oauth2 route overrides app's route #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alasdairtran opened this issue Mar 25, 2024 · 1 comment · Fixed by #12812
Closed

Coder's /oauth2 route overrides app's route #12736

alasdairtran opened this issue Mar 25, 2024 · 1 comment · Fixed by #12812
Assignees
Labels
waiting-for-info The issue creator is asked to provide more information.

Comments

@alasdairtran
Copy link

alasdairtran commented Mar 25, 2024

It looks like recently, Coder introduced a new route handler for /oauth2 in #12240 which conflicts with our own app's route. In our development server, we set up an Ory Hydra's OAuth2 server in the backend and create a Coder app pointing to it. When logging in from our frontend, our login page first makes a request to:

https://hydra--main--workspace--username.coder.example.com/oauth2

where we've set up *.coder.example.com as our CODER_WILDCARD_ACCESS_URL

It used to work normally before #12240 was merged. Unfortunately, Coder now intercepts the request and displays an error message:

{
"message": "OAuth2 provider is under development."
}

Is it possible to disable Coder's built-in /oauth2 route? More generally, I feel that Coder shouldn't intercept any paths under the wildcard access URL.

@coder-labeler coder-labeler bot added bug waiting-for-info The issue creator is asked to provide more information. labels Mar 25, 2024
@Emyrk Emyrk self-assigned this Mar 28, 2024
@Emyrk
Copy link
Member

Emyrk commented Mar 28, 2024

This was fixed here: #12732

I made sure this does not happen again: #12812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info The issue creator is asked to provide more information.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants