Skip to content

chore: ensure root handler has sudomain app mw #12812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore: ensure root handler has sudomain app mw #12812

merged 1 commit into from
Mar 28, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 28, 2024 •
edited
Loading

Enterprise routes like scim touch this. It was overriding routes on subdomains because it existed outside the middleware.

Closes #12736

@Emyrk
chore: ensure root handler has sudomain app mw
16e611f 
Enterprise routes like scim touch this.
@Emyrk Emyrk requested a review from code-asher March 28, 2024 19:36
@Emyrk Emyrk mentioned this pull request Mar 28, 2024
Closed
@Emyrk Emyrk merged commit 8cf1e84 into main Mar 28, 2024
@Emyrk Emyrk deleted the stevenmasley/clean_root_handler branch March 28, 2024 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder's /oauth2 route overrides app's route
2 participants
@Emyrk @code-asher