Skip to content

coder templates edit has no clear purpose #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1101
ammario opened this issue May 4, 2022 · 2 comments · Fixed by #1396
Closed
Tracked by #1101

coder templates edit has no clear purpose #1289

ammario opened this issue May 4, 2022 · 2 comments · Fixed by #1396
Assignees
@f0ssel
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@ammario
Copy link
Member

ammario commented May 4, 2022

  • coder templates edit
  • empty output?

hmm

  • coder templates edit --help
Usage:
  coder templates edit [flags]

Flags:
  -h, --help   help for edit

Global Flags:
      --global-config coder   Path to the global coder config directory (default "/Users/ammar/Library/Application Support/coderv2")```
@ammario ammario mentioned this issue May 4, 2022
Closed
@ammario ammario added this to the V2 Beta milestone May 4, 2022
@tjcran tjcran modified the milestones: V2 Beta, Community MVP May 5, 2022
@tjcran
Copy link

tjcran commented May 7, 2022

A user would expect the templates edit to edit something. We should remove this if it doesn't do anything, or provide a more helpful message about what they should expect to be able to edit with this command.

I assume any actual editing of the template itself would happen in the template file in an editor like vim, rather than via the CLI.

@misskniss misskniss mentioned this issue May 9, 2022
Closed
45 tasks
@ammario
Copy link
Member Author

ammario commented May 9, 2022

@tjcran I'm assuming this is supposed to be analogous with kubectl edit.

It's basically a debugging tool, since all changes are overwritten by the official deployment pipeline.

@f0ssel f0ssel mentioned this issue May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f0ssel f0ssel

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

Remove coder templates edit command coder/coder
4 participants
@misskniss @tjcran @ammario @f0ssel