Skip to content

Document flow for adding a database query #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kylecarbs opened this issue Feb 1, 2022 · 4 comments
Closed

Document flow for adding a database query #131

kylecarbs opened this issue Feb 1, 2022 · 4 comments

Comments

@kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs added this to the MVP milestone Feb 1, 2022
@misskniss misskniss added docs Area: coder.com/docs missing details 👀 api Area: HTTP API labels May 5, 2022
@misskniss
Copy link

Hey team! Please add your planning poker estimate with ZenHub @f0ssel @kylecarbs @johnstcn

@johnstcn
Copy link
Member

What is meant by "documentation" in this case? A README in the source code? A wiki page?

@f0ssel
Copy link
Contributor

f0ssel commented May 17, 2022

I think this can be closed tbh, we seem to do fine without it

@kylecarbs
Copy link
Member Author

Agreed

@misskniss misskniss added invalid 😿 and removed needs grooming 🪒 docs Area: coder.com/docs api Area: HTTP API labels Jun 1, 2022
@misskniss misskniss removed this from the Community MVP milestone Jun 14, 2022
@spikecurtis spikecurtis mentioned this issue Dec 3, 2024
Merged
spikecurtis added a commit that referenced this issue Dec 3, 2024
@spikecurtis
chore: upgrade yamux to 0.1.2 (#15727)
682d350 
Upgrades yamux to 0.1.2, which includes a couple bug fixes.

> Significant Changes
> * Fixed a case where Streams may continue to exist and block operations even after their Session has been closed. #127 ensures when a Session closes that blocking Stream operations exit as well.
> * Allow Reads on locally closed streams. Prior to #131 calling Close() and then Read() on a Stream would fail. Close should only indicate the Stream is done writing. The peer must call Close before Read considers the stream closed. See #131 for details.
> * Tests have been improved significantly. See below for details.

https://github.com/hashicorp/yamux/releases/tag/v0.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@misskniss @johnstcn @kylecarbs @f0ssel