Skip to content

site: Logging out of the dashboard immediately throws an "unexpected application error" when using the Go backend (including production) #13130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parkreiner opened this issue May 2, 2024 · 0 comments · Fixed by #13137
Closed

site: Logging out of the dashboard immediately throws an "unexpected application error" when using the Go backend (including production) #13130

Parkreiner opened this issue May 2, 2024 · 0 comments · Fixed by #13137
Assignees
@Parkreiner
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@Parkreiner
Copy link
Member

Parkreiner commented May 2, 2024 •
edited
Loading

Turning this into an issue for documentation purposes. I'm dropping everything and working on this now, and gunning to have this done by end of day

Updates

  • I think I got this figured out – when we started trying to embed more and more data into the HTML to speed up queries, we didn't update all the query logic to account for the fact that even when we log out, there's still going to be user data in the HTML
    • None of the unit tests caught this because the metadata doesn't exist in the JS runtime – it only exists when we're actually serving files through the Go backend

Steps to reproduce

  1. Log into Coder via Google OAuth (I'm using Coder Dogfood)
  2. Click the user icon in the top-right corner
  3. Click "Sign out"
  4. Immediate "Unexpected application error" based on permissions being unavailable

Video

Screen.Recording.2024-05-02.at.9.17.04.AM.mov

Notes

  • As far as I can tell, this is strictly an issue on the UI side. The log out request is correctly going through, but the UI isn't syncing correctly afterwards
@Parkreiner Parkreiner added site Area: frontend dashboard s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels May 2, 2024
@Parkreiner Parkreiner self-assigned this May 2, 2024
@Parkreiner Parkreiner mentioned this issue May 2, 2024
Merged
@Parkreiner Parkreiner changed the title site: Logging out out of the dashboard immediately throws an "unexpected application error" site: Logging out out of the dashboard immediately throws an "unexpected application error" for Google logins May 2, 2024
@Parkreiner Parkreiner changed the title site: Logging out out of the dashboard immediately throws an "unexpected application error" for Google logins site: Logging out of the dashboard immediately throws an "unexpected application error" for Google logins May 2, 2024
@Emyrk Emyrk mentioned this issue May 2, 2024
Merged
@Parkreiner Parkreiner changed the title site: Logging out of the dashboard immediately throws an "unexpected application error" for Google logins site: Logging out of the dashboard immediately throws an "unexpected application error" when using the Go backend May 3, 2024
@Parkreiner Parkreiner changed the title site: Logging out of the dashboard immediately throws an "unexpected application error" when using the Go backend site: Logging out of the dashboard immediately throws an "unexpected application error" when using the Go backend (including production) May 3, 2024
@Parkreiner Parkreiner mentioned this issue May 3, 2024
Merged
This was referenced May 6, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parkreiner Parkreiner

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
1 participant
@Parkreiner