-
Notifications
You must be signed in to change notification settings - Fork 887
test flake: TestDeleteOldWorkspaceAgentStats
#13430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
s4
Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Comments
It looks like it's going to happen on every commit today, until my PR is merged😭 |
Approved your PR 👍 |
ethanndickson
added a commit
that referenced
this issue
Aug 30, 2024
Fixes #13430. The test for purging old workspace agent stats from the DB was consistently failing when ran with Postgres towards the end of the month, but not with the in-memory DB. This was because month intervals are calculated differently for `time.Time` and the `interval` type in Postgres: ``` ethan=# SELECT '2024-08-30'::DATE AS original_date, ('2024-08-30'::DATE - INTERVAL '6 months') AS sub_date; original_date | sub_date ---------------+--------------------- 2024-08-30 | 2024-02-29 00:00:00 (1 row) ``` Using `func (t Time) AddDate(years int, months int, days int) Time`, where `months` is `-6`: ``` Original: 2024-08-30 00:00:00 +0000 UTC 6 Months Earlier: 2024-03-01 00:00:00 +0000 UTC ``` Since 6 months was chosen arbitrarily, we should be able to change it to 180 days, to remove any ambiguity between the in-memory DB, and the Postgres DB. The alternative solution would involve implementing Postgres' month interval algorithm in Go. The UI only shows stats as old as 168 days (24 weeks), so a frontend change isn't required for the extra days of stats we lose in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Slack context: https://codercom.slack.com/archives/CJURPL8DN/p1717174598761439
Likely due to it being the last of the month.
https://github.com/coder/coder/actions/runs/9325137323/job/25671626698?pr=13429#step:5:345
The text was updated successfully, but these errors were encountered: