Skip to content

flake: TestSSH/RemoteForward #14143

Closed
@dannykopping

Description

@dannykopping

https://github.com/coder/coder/actions/runs/10246342180/job/28343288836?pr=14117

@ethanndickson looks like you touched the code relating to sendTelemetryBackground last (e8db21c), so I assigned this to you.
If this was in error, please reassign it.

==================
WARNING: DATA RACE
Write at 0x00c075c4ad98 by goroutine 42789:
  runtime.racewrite()
      <autogenerated>:1 +0x1e
  github.com/coder/coder/v2/tailnet.(*Conn).Close()
      /home/runner/work/coder/coder/tailnet/conn.go:559 +0x172
  github.com/coder/coder/v2/codersdk/workspacesdk.(*Client).DialAgent.func3()
      /home/runner/work/coder/coder/codersdk/workspacesdk/workspacesdk.go:291 +0x74
  github.com/coder/coder/v2/codersdk/workspacesdk.(*AgentConn).Close()
      /home/runner/work/coder/coder/codersdk/workspacesdk/agentconn.go:77 +0x66
  github.com/coder/coder/v2/cli.(*closerStack).close()
      /home/runner/work/coder/coder/cli/ssh.go:968 +0x47d
  github.com/coder/coder/v2/cli.(*RootCmd).ssh.func1.4.1()
      /home/runner/work/coder/coder/cli/ssh.go:314 +0xd8
  github.com/coder/coder/v2/cli.watchAndClose.func1()
      /home/runner/work/coder/coder/cli/ssh.go:555 +0x62
  runtime.deferreturn()
      /opt/hostedtoolcache/go/1.22.5/x64/src/runtime/panic.go:602 +0x5d
  github.com/coder/coder/v2/cli.(*RootCmd).ssh.func1.4()
      /home/runner/work/coder/coder/cli/ssh.go:311 +0x237

Previous read at 0x00c075c4ad98 by goroutine 37054:
  runtime.raceread()
      <autogenerated>:1 +0x1e
  github.com/coder/coder/v2/tailnet.(*Conn).sendTelemetryBackground()
      /home/runner/work/coder/coder/tailnet/conn.go:786 +0x44
  github.com/coder/coder/v2/tailnet.(*Conn).SendDisconnectedTelemetry()
      /home/runner/work/coder/coder/tailnet/conn.go:745 +0x7a
  github.com/coder/coder/v2/cli.(*RootCmd).ssh.func1()
      /home/runner/work/coder/coder/cli/ssh.go:440 +0x4ed6
  github.com/coder/coder/v2/cli.(*RootCmd).Command.func6.1()
      /home/runner/work/coder/coder/cli/root.go:313 +0x144
  github.com/coder/coder/v2/cli.(*RootCmd).ssh.(*RootCmd).InitClient.func2.1()
      /home/runner/work/coder/coder/cli/root.go:544 +0x3c1
  github.com/coder/coder/v2/cli.(*RootCmd).ssh.RequireNArgs.RequireRangeArgs.func3.1()
      /home/runner/go/pkg/mod/github.com/coder/serpent@v0.7.0/command.go:632 +0x604
  github.com/coder/serpent.(*Invocation).run()
      /home/runner/go/pkg/mod/github.com/coder/serpent@v0.7.0/command.go:441 +0x22c2
  github.com/coder/serpent.(*Invocation).run()
      /home/runner/go/pkg/mod/github.com/coder/serpent@v0.7.0/command.go:377 +0x1849
  github.com/coder/serpent.(*Invocation).Run()
      /home/runner/go/pkg/mod/github.com/coder/serpent@v0.7.0/command.go:536 +0x356
  github.com/coder/coder/v2/cli_test.TestSSH.func13.2()
      /home/runner/work/coder/coder/cli/ssh_test.go:945 +0x5d
  github.com/coder/coder/v2/cli_test.tGo.func2()
      /home/runner/work/coder/coder/cli/ssh_test.go:1665 +0x33

Metadata

Metadata

Assignees

Labels

s4Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions