-
Notifications
You must be signed in to change notification settings - Fork 887
notifications: turn off a notification via email #14389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would suggest a slight rephrasing as simply "Stop receiving emails like this"; I don't think we need to include the template name here. |
@dannykopping I would like to take a look at this |
@joobisb go for it 👍 let me know if you run into any issues. Thanks! |
I believe we cannot make direct API calls from the received email to our backend server due to CORS and other issues, so I was thinking of the following:
wdyt ? |
Sounds good to me @joobisb! |
Hi @BrunoQuaresma, #14520 (comment) continuing this conversation here as I'm unable comment further on the PR Thank you for reviewing the PR and merging it. I appreciate you fixing the Notification stories as well, didn't know we could use decorators to spy the API before the story is rendered coder/site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.stories.tsx Line 107 in 3301212
had one question though, this message was added to show the user which template was disabled, wasn't it needed?
|
@joobisb In order to obtain the template name, we would have to wait for the templates to be fetched, which would block the update request until that process was completed. In my opinion, having the name doesn't provide significant value as it slows down the action. Additionally, since the other toast messages don't include the template name, I think it would be acceptable to omit it. If we believe that including the name in the notification is essential, then we may need to update the API or possibly the email link to provide the name without blocking the delete action. Makes sense? |
@BrunoQuaresma it does. thanks for clarifying! |
A user may receive an email notification from Coder and then want to opt out of that specific template immediately. To support this case, we should add an option to all SMTP notifications that allows users to block a template like so:
Not a blocker for release and implementation depends on customer corroboration of this flow.
This would require a human-readable name for notification templates.
The text was updated successfully, but these errors were encountered: