Skip to content

Support names longer than 32 characters #14408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpmct opened this issue Aug 22, 2024 · 3 comments
Closed

Support names longer than 32 characters #14408

bpmct opened this issue Aug 22, 2024 · 3 comments
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.

Comments

@bpmct
Copy link
Member

bpmct commented Aug 22, 2024

In several places, we limit names to being only 32 characters. We have some users who want to support longer group names for group sync, longer usernames, etc. Can we increase this to at least 36 characters to support GUIDs, which is common for group sync?

Since the group name is an internal field (the display name overrides it), I am not concerned about this causing display issues in the Ui. It may become a problem for usernames, but don't think there's much harm in increasing to 36

Screenshot 2024-08-22 at 5 08 49 PM
@matifali
Copy link
Member

matifali commented Aug 23, 2024

Related to #10708 and #8145

@LMezler
Copy link

LMezler commented Aug 26, 2024

For EnBW this is an urgent topic. We cannot use the group mapping because the groups we use are added dynamically ( we do not know them in advance) and changing the group mapping requires a restart of Coder. And we need to set GUIDs from EntraID as group names to use the group sync feature.

@matifali matifali changed the title Support longer names than 32 characters Support names longer than 32 characters Aug 26, 2024
@bpmct bpmct added the must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. label Aug 26, 2024
@bpmct
Copy link
Member Author

bpmct commented Aug 29, 2024

This is completed and will be in the Sept (v2.15) release

@bpmct bpmct closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.
Projects
None yet
Development

No branches or pull requests

3 participants