Skip to content

Broken support for documented dotfile setup script names #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stevenharman opened this issue Aug 27, 2024 · 3 comments · Fixed by #14455
Closed

Broken support for documented dotfile setup script names #14453

stevenharman opened this issue Aug 27, 2024 · 3 comments · Fixed by #14455

Comments

@stevenharman
Copy link

stevenharman commented Aug 27, 2024 •
edited
Loading

The Coder docs explicitly mention that any of the following list of files can be used for a custom dotfiles setup:

  • install.sh
  • install
  • bootstrap.sh
  • bootstrap
  • script/bootstrap
  • setup.sh
  • setup
  • script/setup

I initially tried script/setup as it aligned well with my dotfiles. However, on booting a Workspace where my dotfiles use script/setup, the file is ignored and the default behavior or symlinking everything kicks in.

snap-2024-08-27-10 53 15

If I switch to setup.sh in the root of the dotfiles, Coder uses that script instead, as expected:

snap-2024-08-27-11 49 25

So either the documentation is wrong, or there's a bug. I'm hoping the later as GitHub CodeSpaces do allow the full list of files.

Version: v2.12.3+534d4ea
@coder-labeler coder-labeler bot added the bug label Aug 27, 2024
@ethanndickson ethanndickson mentioned this issue Aug 27, 2024
Merged
@ethanndickson
Copy link
Member

Good catch, thanks for reporting!

@stevenharman
Copy link
Author

Thanks for the fast turnaround, @ethanndickson. Any idea how long it takes this to propagate to production?

@ethanndickson
Copy link
Member

This'll get included in the next mainline release on the 3rd of September! (First Tuesday of each month)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: detect nested dotfiles scripts coder/coder
2 participants
@stevenharman @ethanndickson