Skip to content

Revisit suspended users being filtered from template permissions query #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
code-asher opened this issue Aug 29, 2024 · 0 comments
Open
Labels
needs decision Needs a higher-level decision to be unblocked.

Comments

@code-asher
Copy link
Member

code-asher commented Aug 29, 2024

Right now the UI is kind of lying about the permissions if a suspended user is there, whether they were added after being suspended or became suspended after the fact.

Reasoning being:

  1. You can add a suspended user, but then it will just not show up which is confusing (and even more sketchy, it does not record in the audit log).
  2. It could cause someone to think a user has no permissions, then if they unsuspend the user "suddenly" they have permissions again.
  3. Someone might know a suspended user had permissions, but when they go to check they cannot see the user and cannot remove the permissions.

But, I am not completely sure about the workflow/use case around suspension so these concerns might be invalid or at least inaccurate.

So, I think we should included suspended users in that query. Alternatively we could prevent adding suspended users in the first place, and remove all their permissions when they become suspended. More work, but depending on what suspension is meant to be maybe it makes more sense to do it that way. Is it a more final action somewhat like deletion, or is it something that should be easily reverted without having to go around adding permissions all over again?

@coder-labeler coder-labeler bot added bug needs decision Needs a higher-level decision to be unblocked. labels Aug 29, 2024
@matifali matifali removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs decision Needs a higher-level decision to be unblocked.
Projects
None yet
Development

No branches or pull requests

2 participants