Skip to content

Metadata dup key yields in internal error #14569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MrPeacockNLB opened this issue Sep 5, 2024 · 1 comment · Fixed by coder/terraform-provider-coder#277
Closed

Metadata dup key yields in internal error #14569

MrPeacockNLB opened this issue Sep 5, 2024 · 1 comment · Fixed by coder/terraform-provider-coder#277

Comments

@MrPeacockNLB
Copy link
Contributor

Description

By accident I want to push a template update to Coder, but this ends in an internal error.

image

After next try I saw another error which was the hint to solve this problem:

image

Expected

Terraform plant should recognize a non uquie key for a metadata object
@coder-labeler coder-labeler bot added the bug label Sep 5, 2024
@ethanndickson ethanndickson mentioned this issue Sep 5, 2024
Merged
@ethanndickson
Copy link
Member

ethanndickson commented Sep 5, 2024 •
edited
Loading

These are unfortunately two different issues.

The second screenshot shows the response from coderd when a new template version is made with the same name as an existing template version for the same template. This message is justifiably confusing, so I'll improve it in #14572.

The same PR will also improve the error message in the first screenshot, when there are duplicate metadata keys, by including the error trace. This error trace is kinda ugly, and ideally it would get picked up during a terraform plan on a template, in which case Terraform would give us a nice human readable error - I'll make a change to the coder provider to support this.

@ethanndickson ethanndickson mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate agent & resource metadata keys during plan coder/terraform-provider-coder
2 participants
@ethanndickson @MrPeacockNLB