Skip to content

Rotate server logs #15309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Oct 31, 2024 · 1 comment · Fixed by #15438
Closed

Rotate server logs #15309

bpmct opened this issue Oct 31, 2024 · 1 comment · Fixed by #15438
Assignees
@defelmnq
Labels
customer-requested Features requested by enterprise customers. Only humans may set this. need-backend Issues that need backend work

Comments

@bpmct
Copy link
Member

bpmct commented Oct 31, 2024

We currently rotate agent logs and had a customer request to rotate the server logs as well for CODER_LOGGING_HUMAN
@coder-labeler coder-labeler bot added customer-requested Features requested by enterprise customers. Only humans may set this. need-backend Issues that need backend work labels Oct 31, 2024
@johnstcn
Copy link
Member

johnstcn commented Nov 4, 2024

This would only be a valid behaviour if Coder is logging directly to a file. If logging to stdout/stderr directly then whatever is consuming that stream should be responsible for log rotation (e.g. journald, kubelet, or docker).

@defelmnq defelmnq mentioned this issue Nov 8, 2024
Merged
@defelmnq defelmnq linked a pull request Nov 8, 2024 that will close this issue
feat(cli): rotate file logs for coderd #15438
Merged
defelmnq added a commit that referenced this issue Nov 12, 2024
@defelmnq
feat(cli): rotate file logs for coderd (#15438)
d6442db 
Related to #15309 

As we already are doing for agent logs - this PR is enabling the logs
rotation for coderd logs.

Currently keeping the same logic than we had for agent - with 5MB as the
file size for rotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defelmnq defelmnq

Labels
customer-requested Features requested by enterprise customers. Only humans may set this. need-backend Issues that need backend work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): rotate file logs for coderd coder/coder
3 participants
@johnstcn @defelmnq @bpmct