Skip to content

site: missing icon for filebrowser #15365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Nov 4, 2024 · 3 comments · Fixed by #15367
Closed

site: missing icon for filebrowser #15365

johnstcn opened this issue Nov 4, 2024 · 3 comments · Fixed by #15367
Assignees
@johnstcn
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard

Comments

@johnstcn
Copy link
Member

johnstcn commented Nov 4, 2024

Problem

Our filebrowser module references /icon/filebrowser.svg but this currently does not exist in our codebase, resulting in a messy-looking filebrowser icon:

Image
@johnstcn johnstcn added s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard labels Nov 4, 2024
@coder-labeler coder-labeler bot added the bug risk Prone to bugs label Nov 4, 2024
@matifali matifali removed the bug risk Prone to bugs label Nov 4, 2024
@johnstcn johnstcn mentioned this issue Nov 4, 2024
Merged
@johnstcn johnstcn self-assigned this Nov 4, 2024
@johnstcn
Copy link
Member Author

johnstcn commented Nov 4, 2024

Fixed by dc29b81

Image

stirby pushed a commit that referenced this issue Nov 4, 2024
@johnstcn @stirby
fix(site/static/icon): add filebrowser icon (#15367)
411a144 
Fixes #15365

We used to hit
https://raw.githubusercontent.com/filebrowser/logo/master/icon_raw.svg
for the filebrowser icon but coder/modules#334 modified the icon URL to
point to a self-hosted icon.

I simply copied the icon from the `coder/modules` repo.

(cherry picked from commit dc29b81)
@stirby stirby mentioned this issue Nov 4, 2024
Merged
stirby added a commit that referenced this issue Nov 4, 2024
@stirby @johnstcn
fix(site/static/icon): add filebrowser icon (#15367) (#15370)
5a6d23a 
Fixes #15365

We used to hit
https://raw.githubusercontent.com/filebrowser/logo/master/icon_raw.svg
for the filebrowser icon but coder/modules#334 modified the icon URL to
point to a self-hosted icon.

I simply copied the icon from the `coder/modules` repo.

(cherry picked from commit dc29b81)

Co-authored-by: Cian Johnston <cian@coder.com>
@gjrtimmer
Copy link

BTW, looks like this is still going on in version 2.16.1, I still have this issue.

johnstcn added a commit that referenced this issue Nov 25, 2024
@johnstcn
fix(site/static/icon): add filebrowser icon (#15367)
dbe2c4e 
Fixes #15365

We used to hit
https://raw.githubusercontent.com/filebrowser/logo/master/icon_raw.svg
for the filebrowser icon but coder/modules#334 modified the icon URL to
point to a self-hosted icon.

I simply copied the icon from the `coder/modules` repo.

(cherry picked from commit dc29b81)
@johnstcn johnstcn mentioned this issue Nov 25, 2024
Merged
@johnstcn
Copy link
Member Author

@gjrtimmer thanks for the heads-up; this one never got cherry-picked to 2.16. It should be fixed in the next patch release for that version.

johnstcn added a commit that referenced this issue Nov 25, 2024
@johnstcn
fix(site/static/icon): add filebrowser icon (#15367) (#15641)
fa0ce56 
Fixes #15365

We used to hit
https://raw.githubusercontent.com/filebrowser/logo/master/icon_raw.svg
for the filebrowser icon but coder/modules#334 modified the icon URL to
point to a self-hosted icon.

I simply copied the icon from the `coder/modules` repo.

(cherry picked from commit dc29b81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site/static/icon): add filebrowser icon coder/coder
3 participants
@johnstcn @gjrtimmer @matifali